fesch / CanZE

Take a closer look at your ZE car
http://canze.fisch.lu
Other
120 stars 70 forks source link

Add new supported car Dacia Spring #750

Open iboboc opened 1 year ago

iboboc commented 1 year ago

Add new supported car Dacia Spring Added Romanian language and prepare for italian

iboboc commented 1 year ago

CanZE build with this changes has been fully tested on Dacia Spring and all features are working as expected. Not tested on Renault Zoe, but changes has been made without impacting existing code.

fesch commented 1 year ago

I didn't have the time yet to check this (heavy period at school right now ;-)) but it is not forgotten!!!

flyser commented 1 year ago

Hi @iboboc, The CSV files seem to be a bit broken. Where did you get this data from or did you just copy it from the zoe? I tried

,7bb,24,39,.000976563,0,3,V,229254,629254,ff,cell minimal voltage 20ms Wxx_cell_v_min_20ms,
,7bb,24,39,.000976563,0,3,V,229255,629255,ff,cell minimal voltage 20ms Wxx_cell_v_max_20ms,

from LBC_Fields.csv and the vehicle responded with a negative response code. also

,7bb,24,39,.000976563,0,3,V,229007,629007,ff,Maximum Cell VoltageWxx_cell_v_max,
,7bb,24,39,.000976563,0,3,V,229009,629009,ff,Minimum Cell VoltageWxx_cell_v_min,

from the same file gives a response, but it rather looks like some cell voltages instead of min&max, because sometimes the max can be lower than the min.

Could you also check the comma separators in these files? seems like there is one missing e.g. before "Wxx_cell_v_min" in the example above