festim-dev / FESTIM-workshop

Learn how to simulate hydrogen transport with FESTIM
Apache License 2.0
15 stars 7 forks source link

Updating task 6 for SOFE #24

Closed jhdark closed 1 year ago

jhdark commented 1 year ago

This task can be developed further by having a better description at the top, reminding why temperture is so important in tritium transport simulations and therefore why heat transfer is built into festim.

Other additional suggestions:

RemDelaporteMathurin commented 1 year ago

These are all very good suggestions.

I think the full monoblock example would overlap with the CAD integration part.

However we could have a 2D problem based on a fenics mesh and we can use fenics.plot(T) to plot the temperature field.

jhdark commented 1 year ago

These are all very good suggestions.

I think the full monoblock example would overlap with the CAD integration part.

However we could have a 2D problem based on a fenics mesh and we can use fenics.plot(T) to plot the temperature field.

Was thinking for the monoblock, we could build the festim sim in a 'my_monoblock' simulation object instead of 'my_model' then in the CAD one we could just have 'from task6 import my_monoblock' and add in all the h transport parameters?

Plus I can test the fenics plotting thing!

RemDelaporteMathurin commented 1 year ago

Don't think you can import from a notebook

RemDelaporteMathurin commented 1 year ago

I think that replacing task 6 by this demo would be better than what we have now