search

festim-dev / FESTIM-workshop

Learn how to simulate hydrogen transport with FESTIM
Apache License 2.0
17 stars 7 forks source link

Task 10: Fitting a TDS spectrum #46

Closed KulaginVladimir closed 7 months ago

KulaginVladimir commented 7 months ago

This PR adds a simple example on how to automatically fit a reference TDS spectrum, based on #10.

The example is made following suggestions, refactoring, and the initial implementation by @RemDelaporteMathurin.

jhdark commented 7 months ago

Might it be worth changing the names of the tasks from task1, task2, to task01, task02 etc so that task 10 comes at the end and then we can expand further?

RemDelaporteMathurin commented 7 months ago

tagging @tjdodwell here since digiLab have an interest in TDS fitting

RemDelaporteMathurin commented 7 months ago

@KulaginVladimir do you think you can change the names of the notebook as per James' comment? If @ehodille doesn't have any remark I'll merge this after this change

ehodille commented 7 months ago

Ok, sorry for the time I took to reply to this. I was confuse about what was in the "file changed". And James just told me to go check in Vladimir fork. I am happy with this example, thank you very much with this.