search

festim-dev / FESTIM-workshop

Learn how to simulate hydrogen transport with FESTIM
Apache License 2.0
15 stars 7 forks source link

Outdated links in Task 1 and Task 3 #48

Open KulaginVladimir opened 5 months ago

KulaginVladimir commented 5 months ago

Some links in Task 1 are outdated:

https://github.com/festim-dev/FESTIM-workshop/blob/987d27c0ffe4337c40613f2030843f0c50f46786/tasks/task01.ipynb#L127-L128

https://github.com/festim-dev/FESTIM-workshop/blob/987d27c0ffe4337c40613f2030843f0c50f46786/tasks/task01.ipynb#L176

I also missed this one in #46. Sorry about that. https://github.com/festim-dev/FESTIM-workshop/blob/987d27c0ffe4337c40613f2030843f0c50f46786/tasks/task01.ipynb#L155

and in Task 3:

https://github.com/festim-dev/FESTIM-workshop/blob/987d27c0ffe4337c40613f2030843f0c50f46786/tasks/task03.ipynb#L349

RemDelaporteMathurin commented 5 months ago

The links to the docs should be easy to fix. To fix the link to the image in Task 3 one would need to rerun the notebook to obtain it 😄