festim-dev / FESTIM

Coupled hydrogen/tritium transport and heat transfer modelling using FEniCS
https://festim.readthedocs.io/en/stable/
Apache License 2.0
90 stars 23 forks source link

Refactor `create_value_fenics` for source and fluxes #750

Closed RemDelaporteMathurin closed 5 months ago

RemDelaporteMathurin commented 5 months ago

Proposed changes

Based on a discussion I had with @jhdark we realised that we only needed to interpolate values onto a Function for dirichletBCs (and maybe InitialConditions). For fluxes and sources, since those are added into the formulation we can just put space-time dependent expressions as a ufl Expression, moreover it doesn't need to be updated in this case.

This is a first step towards #749

Types of changes

What types of changes does your code introduce to FESTIM?

Checklist

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.42%. Comparing base (aac14ac) to head (6e1cf21). Report is 10 commits behind head on fenicsx.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## fenicsx #750 +/- ## =========================================== - Coverage 98.49% 98.42% -0.08% =========================================== Files 28 28 Lines 1532 1519 -13 =========================================== - Hits 1509 1495 -14 - Misses 23 24 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.