Open RemDelaporteMathurin opened 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 98.43%. Comparing base (
3fc02da
) to head (e93598b
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@KulaginVladimir would you like to give this a look?
Proposed changes
This PR fixes #727 Needs to be merged after #752
Also some refactoring. Got rid of
HTransportProblem.create_flux_value_fenics
and merged it withdefine_boundary_conditions
(which breaks some of the tests). I happy to not do this here and keep it for another PR.Todo:
Types of changes
What types of changes does your code introduce to FESTIM?
Checklist
Further comments
@jhdark I chose not to make this a special case of the very generic class ParticleFluxBC (ie using a lambda function for value) to keep a simple implementation.