search

festim-dev / FESTIM

Coupled hydrogen/tritium transport and heat transfer modelling using FEniCS
https://festim.readthedocs.io/en/stable/
Apache License 2.0
90 stars 23 forks source link

`tqdm.auto` instead of `tqdm.autonotebook` + refresh #759

Closed RemDelaporteMathurin closed 5 months ago

RemDelaporteMathurin commented 5 months ago

I noticed that when running in notebooks there was a bunch of warnings from tqdm.

After a bit of reading (https://github.com/jmcarpenter2/swifter/pull/67) I switched autonotebook to auto and that got rid of the warning.

Also, the progress bar in notebooks is slick!

image

I also added a refresh call after the timestepping loop to make sure the bar displays 100% (and even still sometimes it doesn't work...)

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.49%. Comparing base (f75ac21) to head (fa260c3). Report is 1 commits behind head on fenicsx.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## fenicsx #759 +/- ## ======================================== Coverage 98.49% 98.49% ======================================== Files 28 28 Lines 1532 1533 +1 ======================================== + Hits 1509 1510 +1 Misses 23 23 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.