search

festim-dev / FESTIM

Coupled hydrogen/tritium transport and heat transfer modelling using FEniCS
https://festim.readthedocs.io/en/stable/
Apache License 2.0
90 stars 23 forks source link

Fix units for "retention" with TotalVolume and TotalSurface #767

Closed RemDelaporteMathurin closed 4 months ago

RemDelaporteMathurin commented 4 months ago

Fix for #765

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.51%. Comparing base (24420e6) to head (12edfdf). Report is 233 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #767 +/- ## ======================================= Coverage 99.51% 99.51% ======================================= Files 58 58 Lines 2468 2474 +6 ======================================= + Hits 2456 2462 +6 Misses 12 12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

RemDelaporteMathurin commented 4 months ago

so what we could update it to a good first issue

We already have quite a few good first issues and they seem to be left untouched haha We'll probably have to close a few before 1.3 btw