festim-dev / FESTIM

Coupled hydrogen/tritium transport and heat transfer modelling using FEniCS
https://festim.readthedocs.io/en/stable/
Apache License 2.0
78 stars 16 forks source link

Add error message when no final time is provided in transient simulations #769

Closed RemDelaporteMathurin closed 1 month ago

RemDelaporteMathurin commented 1 month ago

Proposed changes

As described in this Discourse topic when users don't provide final_time to settings when running a transient simulation, the error is not explanatory.

This PR simply adds a check to initialise() and raises a dedicated error message.

Types of changes

What types of changes does your code introduce to FESTIM?

Checklist

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.51%. Comparing base (315aebd) to head (38677a7).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #769 +/- ## ======================================= Coverage 99.51% 99.51% ======================================= Files 58 58 Lines 2476 2478 +2 ======================================= + Hits 2464 2466 +2 Misses 12 12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.