festim-dev / FESTIM

Coupled hydrogen/tritium transport and heat transfer modelling using FEniCS
https://festim.readthedocs.io/en/stable/
Apache License 2.0
90 stars 23 forks source link

Temperature can be given as float or sp.Expr #770

Closed RemDelaporteMathurin closed 3 months ago

RemDelaporteMathurin commented 4 months ago

Proposed changes

This fixes #741 by adding a setter/getter to the T attribute of Simulation.

Now, users can simply give the temperature as a numerical value or sympy Expression without having to create a Temperature object.

Little QoL improvement!

Types of changes

What types of changes does your code introduce to FESTIM?

Checklist

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.52%. Comparing base (fb2c99f) to head (6cb7559). Report is 196 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #770 +/- ## ======================================= Coverage 99.51% 99.52% ======================================= Files 58 58 Lines 2488 2501 +13 ======================================= + Hits 2476 2489 +13 Misses 12 12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.