Closed RemDelaporteMathurin closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 99.53%. Comparing base (
fb2c99f
) to head (09143db
). Report is 40 commits behind head on main.:exclamation: Current head 09143db differs from pull request most recent head 3af630d
Please upload reports for the commit 3af630d to get more accurate results.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@RemDelaporteMathurin, I followed the guide. In my opinion, it's nice! However, it's a bit hard to read, since the bullet points are just stacked to screenshots, but not really a problem.
Possibly, a 3D example could be a better choice, as it's usually easier to do a simpler case based on a more complex example, rather than otherwise. What do you think?
Moreover, what does the last screenshot show? I expected a mesh representation in ParaView (similar to the mesh in SALOME from the pre-last screenshot of your guide). By default, I get this view in ParaView:
it's a bit hard to read, since the bullet points are just stacked to screenshots, but not really a problem.
I adapted the size of the images let me know what you think
Moreover, what does the last screenshot show? I expected a mesh representation in ParaView (similar to the mesh in SALOME from the pre-last screenshot of your guide). By default, I get this view in ParaView:
So we discussed about this on the side and it appeared that this is just from using the wrong XDMF reader in Paraview. Maybe similar to this PR we need a small Paraview tutorial or at least write somewhere which reader users should use.
@KulaginVladimir @jhdark I added the CAD based workflow, let me know what you think
Proposed changes
This is an attempt at a simple SALOME to FESTIM tutorial advancing towards #739.
Types of changes
What types of changes does your code introduce to FESTIM?