search

festim-dev / FESTIM

Coupled hydrogen/tritium transport and heat transfer modelling using FEniCS
https://festim.readthedocs.io/en/stable/
Apache License 2.0
87 stars 22 forks source link

Soret effect in cylindrical/spherical coordinates #818

Closed KulaginVladimir closed 1 month ago

KulaginVladimir commented 1 month ago

Currently, the Soret effect can be used with cartesian meshes. It would be nice to extend the functionality for cylindrical and spherical cases.

RemDelaporteMathurin commented 1 month ago

Yep, that's my bad.

At the time I didn't need Soret for cylindrical applications and I was too lazy to figure out how/if the equations would change for Soret in cylindrical (I guess so?).

KulaginVladimir commented 1 month ago

We just have to use a proper gradient, no? So, the Soret term in the form would be similar to the Fick diffusion term.

RemDelaporteMathurin commented 1 month ago

Yep, in theory that's all.

We'll need to have a verification case for this formulation (that could go in https://github.com/festim-dev/V-V-report/issues/64)

KulaginVladimir commented 1 month ago

I can do it, since I'd need Soret in cylindrical coordinates.

Moreover, if #723 is going to be solved before v1.3, I can try to make it in time too.