Closed RemDelaporteMathurin closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 99.56%. Comparing base (
10bfae9
) to head (4e45b4a
). Report is 68 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Could take the opportunity to add the attributes to the child classes, but not necessary
What child classes?
Could take the opportunity to add the attributes to the child classes, but not necessary
What child classes?
SurfaceFluxCylindrical and SurfaceFluxSpherical
Could take the opportunity to add the attributes to the child classes, but not necessary
What child classes?
SurfaceFluxCylindrical and SurfaceFluxSpherical
Well that's already what this PR is doing 😕
Proposed changes
Fix for #828
We should add this units property to all derived quantities!
Types of changes
What types of changes does your code introduce to FESTIM?
Checklist