Fixed Simulation.exports setter

festim-dev / FESTIM

Coupled hydrogen/tritium transport and heat transfer modelling using FEniCS

https://festim.readthedocs.io/en/stable/

Apache License 2.0

92 stars 24 forks source link

Fixed Simulation.exports setter #836

Closed RemDelaporteMathurin closed 3 months ago

RemDelaporteMathurin commented 3 months ago

Proposed changes

Fixes #833

Types of changes

What types of changes does your code introduce to FESTIM?

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Code refactoring
[ ] Documentation Update (if none of the other choices apply)
[ ] New tests

Checklist

[x] Black formatted
[x] Unit tests pass locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.58%. Comparing base (31864c8) to head (d34a463). Report is 72 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #836 +/- ## ========================================== + Coverage 99.55% 99.58% +0.02% ========================================== Files 61 61 Lines 2724 2874 +150 ========================================== + Hits 2712 2862 +150 Misses 12 12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

RemDelaporteMathurin commented 3 months ago

@KulaginVladimir would you mind giving this a quick look? I think this is a result of these classes now inheriting from list