festim-dev / FESTIM

Coupled hydrogen/tritium transport and heat transfer modelling using FEniCS
https://festim.readthedocs.io/en/stable/
Apache License 2.0
92 stars 24 forks source link

created shared Problem class for HeatTransferProblem and HTransportProblem #857

Closed rekomodo closed 3 months ago

rekomodo commented 3 months ago

Solve #745

Proposed changes

Created a common Problem class to house functionality common to both HeatTransferProblem and HTransportProblem.

Types of changes

What types of changes does your code introduce to FESTIM?

Checklist

Further comments

Problem class has no docstring yet.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.92%. Comparing base (4e2afe8) to head (b29e8d9). Report is 211 commits behind head on fenicsx.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## fenicsx #857 +/- ## =========================================== - Coverage 98.95% 98.92% -0.04% =========================================== Files 35 36 +1 Lines 1631 1580 -51 =========================================== - Hits 1614 1563 -51 Misses 17 17 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.