Closed XinShen-CHN closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 99.56%. Comparing base (
21591ed
) to head (2a53526
). Report is 47 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hi @XinShen-CHN, could you please add this logo for MEPhI?
The source file can be downloaded with this link: https://mephi.ru/content/public/uploads/files/angl.zip or this: https://logowik.com/national-research-nuclear-university-mephi-logo-vector-svg-pdf-ai-eps-cdr-free-download-16416.html
Hi @XinShen-CHN, could you please add this logo for MEPhI?
The source file can be downloaded with this link: https://mephi.ru/content/public/uploads/files/angl.zip or this: https://logowik.com/national-research-nuclear-university-mephi-logo-vector-svg-pdf-ai-eps-cdr-free-download-16416.html
Sure.
Thanks Xin! Could you please format your code with black?
Install black:
pip install black
Format your script:
black map.py
I'd love to, but I'm stuck with formatting the code with black.
I'd love to, but I'm stuck with formatting the code with black.
I can help. What is your issue?
I'd love to, but I'm stuck with formatting the code with black.
I can help. What is your issue?
Thank you! No worries. I think I've settled it.
New problem. It has been loading for hours after I clicked the commit.
New problem. It has been loading for hours after I clicked the commit. ![image](https://private-user-
Have you entered a commit message before clicking "Commit"?
New problem. It has been loading for hours after I clicked the commit. ![image](https://private-user-
Have you entered a commit message before clicking "Commit"?
Thanks! I'm not familar with the desktop version of VS Code for using it first time.
Thanks @XinShen-CHN for this improvement! 🚀🚀
General feedback: you should try to have commits message that are specific to the changes in each commit. Here all the commits have the same message. A specific message would be for example "formatted code with black" or "moved files to subdirectory", "changed variable names" etc.
Got it!
@XinShen-CHN I just pushed to your branch to add the changes added by @iamryo on #853
Proposed changes
Store user logos locally to avoid missing markers in map.
Types of changes
What types of changes does your code introduce to FESTIM?
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...