festim-dev / FESTIM

Coupled hydrogen/tritium transport and heat transfer modelling using FEniCS
https://festim.readthedocs.io/en/stable/
Apache License 2.0
92 stars 24 forks source link

Store user logos locally to avoid missing markers in map #862

Closed XinShen-CHN closed 3 months ago

XinShen-CHN commented 3 months ago

Proposed changes

Store user logos locally to avoid missing markers in map.

Types of changes

What types of changes does your code introduce to FESTIM?

Checklist

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.56%. Comparing base (21591ed) to head (2a53526). Report is 47 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #862 +/- ## ======================================= Coverage 99.56% 99.56% ======================================= Files 61 61 Lines 2750 2750 ======================================= Hits 2738 2738 Misses 12 12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

KulaginVladimir commented 3 months ago

Hi @XinShen-CHN, could you please add this logo for MEPhI? С конём и дескриптором

The source file can be downloaded with this link: https://mephi.ru/content/public/uploads/files/angl.zip or this: https://logowik.com/national-research-nuclear-university-mephi-logo-vector-svg-pdf-ai-eps-cdr-free-download-16416.html

XinShen-CHN commented 3 months ago

Hi @XinShen-CHN, could you please add this logo for MEPhI? С конём и дескриптором

The source file can be downloaded with this link: https://mephi.ru/content/public/uploads/files/angl.zip or this: https://logowik.com/national-research-nuclear-university-mephi-logo-vector-svg-pdf-ai-eps-cdr-free-download-16416.html

Sure.

XinShen-CHN commented 3 months ago

Thanks Xin! Could you please format your code with black?

Install black:

pip install black

Format your script:

black map.py

I'd love to, but I'm stuck with formatting the code with black.

RemDelaporteMathurin commented 3 months ago

I'd love to, but I'm stuck with formatting the code with black.

I can help. What is your issue?

XinShen-CHN commented 3 months ago

I'd love to, but I'm stuck with formatting the code with black.

I can help. What is your issue?

Thank you! No worries. I think I've settled it.

XinShen-CHN commented 3 months ago

New problem. It has been loading for hours after I clicked the commit. image

RemDelaporteMathurin commented 3 months ago

New problem. It has been loading for hours after I clicked the commit. ![image](https://private-user-

Have you entered a commit message before clicking "Commit"?

XinShen-CHN commented 3 months ago

New problem. It has been loading for hours after I clicked the commit. ![image](https://private-user-

Have you entered a commit message before clicking "Commit"?

Thanks! I'm not familar with the desktop version of VS Code for using it first time.

XinShen-CHN commented 3 months ago

Thanks @XinShen-CHN for this improvement! 🚀🚀

General feedback: you should try to have commits message that are specific to the changes in each commit. Here all the commits have the same message. A specific message would be for example "formatted code with black" or "moved files to subdirectory", "changed variable names" etc.

Got it!

RemDelaporteMathurin commented 3 months ago

@XinShen-CHN I just pushed to your branch to add the changes added by @iamryo on #853