This is a "Follow best practices" pull request, that builds on top of #40
It is not recommended to have using namespace std; on headers (see for details: https://stackoverflow.com/a/1452759/446149). Basically your users may not want to bring all of the std namespace, and it is not fair to enforce that. I've seen issues at
This pull request does not remove using namespace std; from headers (yet), but rather adds that instruction to all compilation units (.cc files). Later, there will be a pull request that does the removal of that instruction from the headers.
I did not want to break festival in this PR, that's why I did not remove the using namespace std; here
This is a "Follow best practices" pull request, that builds on top of #40
It is not recommended to have
using namespace std;
on headers (see for details: https://stackoverflow.com/a/1452759/446149). Basically your users may not want to bring all of the std namespace, and it is not fair to enforce that. I've seen issues atThis pull request does not remove
using namespace std;
from headers (yet), but rather adds that instruction to all compilation units (.cc files). Later, there will be a pull request that does the removal of that instruction from the headers.I did not want to break festival in this PR, that's why I did not remove the
using namespace std;
here