search

festvox / speech_tools

Edinburgh Speech Tools
Other
56 stars 25 forks source link

Make build reproducible #46

Open sthibaul opened 3 years ago

sthibaul commented 3 years ago

eade31a68ec7 ("Honor environment variables passed at ./configure") made speech_tools record build flags in user_flags.mak. This however make the build less reproducible by recording flags from the environment. Also, external applications using it do not actually need to get flags from that, they can just inherit them from their own environment. Actually, I'd even argue that this is preferrable over seeing speech_tools hardcode flags that applications using its build system will then have to use.

lenzo-ka commented 3 years ago

I'm hoping to get to this shortly... I'd like to test and get a couple other things in first and make sure we don't have conflicts, but this is a good thing to do!