Closed jrriehl closed 2 years ago
Visit the preview URL for this PR (updated for commit 7596c05):
https://fetch-docs-preview--pr2741-feat-oracle-skills-u-s08lyxmo.web.app
(expires Thu, 14 Jul 2022 08:16:01 GMT)
🔥 via Firebase Hosting GitHub Action 🌎
@solarw please resolve the merge conflicts.
Merging #2741 (3e328fb) into develop (5ae92cc) will decrease coverage by
0.00%
. The diff coverage isn/a
.:exclamation: Current head 3e328fb differs from pull request most recent head c47d6ae. Consider uploading reports for the commit c47d6ae to get more accurate results
@@ Coverage Diff @@
## develop #2741 +/- ##
===========================================
- Coverage 97.96% 97.96% -0.01%
===========================================
Files 522 522
Lines 36498 36498
===========================================
- Hits 35757 35754 -3
- Misses 741 744 +3
Flag | Coverage Δ | |
---|---|---|
unittests | 97.96% <ø> (-0.01%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
aea/connections/base.py | 98.18% <0.00%> (-1.82%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 5ae92cc...c47d6ae. Read the comment docs.
@solarw Failure for test_simple_oracle.py. I think it is minor and just needs an update to a package number (0.17.0
to 0.17.1
).
Proposed changes
Simplifies oracle skills by removing the libp2p connection and defaulting to the
fetchai
ledger.Types of changes
What types of changes does your code introduce to agents-aea? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply.develop
branch (left side). Also you should start your branch off ourdevelop
.