Closed solarw closed 2 years ago
Merging #2753 (fbf953e) into main (8a60889) will decrease coverage by
0.38%
. The diff coverage is81.57%
.
@@ Coverage Diff @@
## main #2753 +/- ##
==========================================
- Coverage 98.46% 98.07% -0.39%
==========================================
Files 522 540 +18
Lines 36300 37539 +1239
==========================================
+ Hits 35742 36818 +1076
- Misses 558 721 +163
Flag | Coverage Δ | |
---|---|---|
unittests | 98.07% <81.57%> (-0.39%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
aea/protocols/generator/common.py | 100.00% <ø> (ø) |
|
packages/fetchai/protocols/acn/__init__.py | 100.00% <ø> (ø) |
|
packages/fetchai/protocols/aggregation/__init__.py | 100.00% <ø> (ø) |
|
...s/fetchai/protocols/aggregation/aggregation_pb2.py | 69.56% <ø> (ø) |
|
...ackages/fetchai/protocols/contract_api/__init__.py | 100.00% <ø> (ø) |
|
...fetchai/protocols/contract_api/contract_api_pb2.py | 57.14% <ø> (ø) |
|
packages/fetchai/protocols/cosm_trade/__init__.py | 100.00% <ø> (ø) |
|
...ges/fetchai/protocols/cosm_trade/cosm_trade_pb2.py | 62.85% <ø> (ø) |
|
packages/fetchai/protocols/default/__init__.py | 100.00% <ø> (ø) |
|
packages/fetchai/protocols/fipa/__init__.py | 100.00% <ø> (ø) |
|
... and 142 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 8a60889...fbf953e. Read the comment docs.
that'd be great to fill the PR descriptions with some helpful stuff for history/search/and people not following closely the project to get an idea of what's going on.
Absolutely right! We will enforce this from now on :)
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
Fixes
If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to agents-aea? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply.develop
branch (left side). Also you should start your branch off ourdevelop
.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...
DELETE INCLUSIVE THIS AND BELOW FOR STANDARD PR
Release summary
Version number: [e.g. 1.0.1]
Release details
Describe in short the main changes with the new release.
Checklist
Put an
x
in the boxes that apply.main
branch (left side), fromdevelop
scripts/generate_ipfs_hashes.py
)HISTORY.md
for this releaseaea/__version__.py
file.latest
(check the READMEs of
aea-develop
andaea-user
)aea
to PyPI.Further comments
Write here any other comment about the release, if any.