Updated protobuf and jsonschema.

mariacarmina commented 1 year ago

Proposed changes

Updated protobuf and jsonschema versions for further development.

Fixes

Fixes #2814

Types of changes

What types of changes does your code introduce to agents-aea? Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply.

[X] I have read the CONTRIBUTING doc
[X] I am making a pull request against the develop branch (left side). Also you should start your branch off our develop.
[] Lint and unit tests pass locally with my changes and CI passes too
[] I have added tests that prove my fix is effective or that my feature works
[X] I have checked that code coverage does not decrease.
[X] I have added necessary documentation (if appropriate)
[X] Any dependent changes have been merged and published in downstream modules

mariacarmina commented 1 year ago

@solarw I saw that you opened a PR which is related with what I described in #2814. I have done some new changes on this branch and I was wondering if you can approve the CI workflows to run please. Thanks!

5A11 commented 1 year ago

@mariacarmina Thanks for your PR. Please address the above comments, otherwise should be ready to go.

mariacarmina commented 1 year ago

The PR should be based off of and against developand not main.

I have changed the base to develop.

mariacarmina commented 1 year ago

I have updated the poetry.lock file. The CI was complaining about python-mbedtls (==2.2.0) package which was present before.

mariacarmina commented 1 year ago

The remaining failing tests are: python code quality checks score which is 9.99/10 and golang checks on MacOS system. I have searched the error for golang, but the solution for it, it's related to re-compile the go files or something similar. In order to do that, I exported the PATH env var for go installation as I saw here

5A11 commented 1 year ago

@mariacarmina thanks for your contribution. CI is failing on some pylint issue. In the interest of time, we have created a PR #2815 that passes CI (mostly except flaky tests) and achieves the same. Do you want to have a look and if you are happy approve?

mariacarmina commented 1 year ago

@mariacarmina thanks for your contribution. CI is failing on some pylint issue. In the interest of time, we have created a PR #2815 that passes CI (mostly except flaky tests) and achieves the same. Do you want to have a look and if you are happy approve?

yes, I can take a look over that PR, sure. Thanks for letting me know.

5A11 commented 1 year ago

Thanks again for your contribution @mariacarmina and reviewing #2815. That PR is now merged and so this can be closed.

fetchai / agents-aea