Feat/parameter scan - Githubissues

fetchai / agents-tac

Competition and Agent Frameworks for the Trading Agents Competition

https://fetchai.github.io/agents-tac

Apache License 2.0

28 stars 8 forks source link

Feat/parameter scan #334

Closed marcofavorito closed 5 years ago

marcofavorito commented 5 years ago

Proposed changes

This PR implements a page in the GUI app to submit multiple experiments to the sandbox server with different configurations.

Fixes

fixes #298

Types of changes

What types of changes does your code introduce to agents-tac? Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[X] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply.

[X] I have read the CONTRIBUTING doc
[X] I am making a pull request against the develop branch (left side). Also you should start your branch off our develop.
[X] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in downstream modules

Further comments

It's not easy to set up ranges of parameters on where to define the grid search. A future improvement might include facilities to run implicitly multiple experiments by specifying the ranges of parameters, like a true grid search.
It would be useful to have a Python script to run that grid search, instead of only via the GUI (as specified in #298 ).

DavidMinarsch commented 5 years ago

When the sandbox is finished the start button should be enabled again.

Screenshot 2019-08-09 at 17 02 45

DavidMinarsch commented 5 years ago

Looks ok for merging for now