fix: bridge contract remove hardcoded address

fetchai / ledger-subquery

This is the Fetch Ledger SubQuery project, an indexer for the Fetch network.

MIT License

2 stars 10 forks source link

Closed daeMOn63 closed 2 years ago

daeMOn63 commented 2 years ago

Remove the hardcoded address on the handleLegacyBridgeSwap, as this address is dependant on the number of previously stored / instantiated contracts
Instead extract the contract address from the swap tx, which should still allow querying all swaps for a particular contract
rename BaseContract to BridgeContract, in anticipation of supporting other kinds of contracts (ie: CW20)
reduced sleep time in TestContractSwap to wait only for indexer to pickup the messages, it now wait for the swap tx using cosmpy wait_for_query_tx()

daeMOn63 commented 2 years ago

Good point, tested with another contract accepting a different "swap" message, and fixed in 485084c
I think this is not the right approach. I expect the indexer to index stuff, and not have to call for a developer & make a release every time someone deploys or migrates a contract. "forcing users to lookup the current addresses out of band" sounds more like the responsibility of some frontend services, as well as it's probably reasonable not to expect end users to build queries on their own. That's why I think exposing the ability to query and filter by contract address seems more important than restricting the indexing to a few chosen contracts. But it's your call I guess :)