fetchrobotics / docs

Robot User Manuals
11 stars 34 forks source link

Allow users to run the simulation on ROSDS - The Construct #58

Closed rosject closed 5 years ago

rosject commented 6 years ago

Hi all,

in this PR I've basically added a subsection called Launch right now on ROSDS under the section Tutorial: Gazebo Simulation. ROSDS stands for ROS Development Studio.

On the Launch right now on ROSDS subsection we have a button called Run on ROSDS which allows users to run fetch_robot on ROSDS without any installation.


PS: I've generated the html and the pdf file according to the instructions on the master branch and I've noticed that on the FetchRobotics.pdf file there are some images on the wrong place. Turns out that this problem was not introduced in this Pull Request. It was already on "production", as can be seen on page 41 of FetchRobotics.pdf of this repo, on the gh-pages branch. The pdf file was generated on Dec 19, 2017 902e219.

rubenanapu commented 6 years ago

Hi @moriarty (I'm mentioning you here because you are the person I saw on https://github.com/orgs/fetchrobotics/people

Is there a specific requirement to possibly merge this Pull Request? Or if you are not the person responsible for that, do you know who should I contact?

I'm looking forward to hearing from you.

moriarty commented 6 years ago

Thanks, I think @erelson & @rctoris would be the better people to tag.

moriarty commented 6 years ago

The ROS DS looks pretty cool, but I think we might want to rearrange this PR.

I think we could put a note in the opening section, and then move the actual Launch on ROS Developer Studio further down. Just because the primary audience of these docs are the customers who have a Fetch or Freight, and they're getting the reference to these docs for setting up their computers. I don't want to confuse the users and have them then go out and think they need to sign up for another service, but I do think it's a cool service and seems very easy to use so they should know the option exists, and have it near the top in case they're just browsing the docs and want to give it a try.

So for example:

But I actually haven't contributed to the docs, nor do I have merge rights to this repo (yet), so I would wait for @rctoris and @erelson to reply.

rubenanapu commented 6 years ago

Hi @moriarty!

Thank you very much for your feedback. I've just made the changes you suggested so that user won't think they need to sign up for another service to test the simulation.

Let's see whether @erelson or @rctoris have any other recommendation.

moriarty commented 5 years ago

@erelson, I don't have merge access on this repo... But I just spoke with @mmwise and we're good to merge this.

@rubenanapu sorry for the delay, I just received an email from The Construct which reminded me of this PR.

rubenanapu commented 5 years ago

Thanks @moriarty

Let me know if you need any action from my side.

moriarty commented 5 years ago

@erelson this went into :master instead of :gh-pages., can you update :gh-pages.

erelson commented 5 years ago

Thanks for your patience; it's now live! http://docs.fetchrobotics.com/gazebo.html#launch-it-on-rosds

(master branch was correct; @moriarty forgot this was a restructuredtext -> sphinx -> HTML shindig)