search

fetherston / npm-parrot-minidrone

Fly Parrot MiniDrones with Node JS
83 stars 24 forks source link

Update required to get Parrot Mambo Bebop working #16

Open jwvictor opened 7 years ago

jwvictor commented 7 years ago

This field was undefined for whatever reason, so handled for that case. It still finds that the other ID starts with Mambo_ so not a huge deal, but caused it to crash with my device (Parrot Mambo Bebop Minidrone). Thought you might like the update.

fetherston commented 7 years ago

@jwvictor thanks for the update! However, please setup eslint in your text editor and fix the changes to match the repositories lint rules (Note the failing build step in github).

fetherston commented 7 years ago 
The command "npm test" exited with 0.
1.55s$ ./node_modules/.bin/eslint-changes
/Users/travis/build/fetherston/npm-parrot-minidrone/lib/MiniDroneBtAdapter.js
  407:9   error  Expected space(s) after "if"                              keyword-spacing
  407:22  error  Missing space before opening brace                        space-before-blocks
  408:17  error  Expected indentation of 12 space characters but found 16  indent
jwvictor commented 7 years ago

@fetherston Thank you so much for having a look, would love to commit to your project even in some small form -- I have had so much fun with it already, I certainly owe you :) I don't write much JS so I'll grab a copy of eslint and resubmit the PR as soon as I can. Thanks again!

jwvictor commented 7 years ago

@fetherston put in the changes the linter was asking for, CI should pass but it's taking a while :) lemme know if there's any trouble!