fetlife / rollout

Feature flippers.
MIT License
2.89k stars 212 forks source link

Percentage Rollout on rails view #126

Open kirykr opened 7 years ago

kirykr commented 7 years ago

I have tried to limit users by 20 percent but seemed all the users can see the view that I blocked

- if $rollout.active? :percentage_rollout, current_user
    %h2
      Hello
      =current_user.first_name

my initial instance

    $name_space = Redis::Namespace.new(Rails.env, redis: $redis)
    $rollout = Rollout.new($name_space)
    $rollout.define_group(:percetage_users) do |user|
      user
    end
    $rollout.activate_users(:percentage_rollout, User.all)
    $rollout.deactivate_group(:percentage_rollout, :percentage_users)

    $rollout.activate_percentage :percentage_rollout, 20

please correct me if what i did wrong here?, thanks

p-salido commented 6 years ago

@kirykr $rollout.activate_users(:percentage_rollout, User.all) activates for all users, subsequent group/percentage activations and deactivations don't matter. See #87.

Bertg commented 6 years ago

This issue seems to have a solution. Suggest to close this issue.