search

fetlife / rollout

Feature flippers.
MIT License
2.89k stars 212 forks source link

Fix crash on multi_get when calling with empty features #144

Closed Seitk closed 4 years ago

Seitk commented 4 years ago

In the latest build 2.4.4 we have #143 merged and start using multi_get in feature_states and active_features but it will raise error when it's called with empty features (that's pretty common when we are running rspec on a test database)

       Failure/Error: $rollout.feature_states(user)

       Redis::CommandError:
         ERR wrong number of arguments for 'mget' command
       # ./vendor/bundle/ruby/2.4.0/gems/redis-4.1.2/lib/redis/client.rb:126:in `call'
       # ./vendor/bundle/ruby/2.4.0/gems/redis-4.1.2/lib/redis.rb:930:in `block in mget'
       # ./vendor/bundle/ruby/2.4.0/gems/redis-4.1.2/lib/redis.rb:52:in `block in synchronize'
       # ./vendor/bundle/ruby/2.4.0/gems/redis-4.1.2/lib/redis.rb:52:in `synchronize'
       # ./vendor/bundle/ruby/2.4.0/gems/redis-4.1.2/lib/redis.rb:929:in `mget'
       # ./vendor/bundle/ruby/2.4.0/gems/rollout-2.4.4/lib/rollout.rb:268:in `multi_get'
       # ./vendor/bundle/ruby/2.4.0/gems/rollout-2.4.4/lib/rollout.rb:276:in `feature_states'
reneklacan commented 4 years ago

@Seitk good catch, thank you very much!

reneklacan commented 4 years ago

Released in 2.4.5