fetlife / rollout

Feature flippers.
MIT License
2.89k stars 212 forks source link

Improve Ergonomics of Rollout::Feature#active? #155

Closed reneklacan closed 3 years ago

reneklacan commented 3 years ago

This changes signature of Rollout::Feature#active? to not require rollout instance as first argument.

When querying same feature for different users, it was required to do something like:

feature = $rollout.get(:foo)
users.each do |user|
   puts feature.active?($rollout, user)
end

This PR changes API so it's possible to just do:

feature = $rollout.get(:foo)
users.each do |user|
   puts feature.active?(user)
end

Note: This API was never advertised but just to be sure, we just bump major version when releasing this change.