search

fetlife / rollout

Feature flippers.
MIT License
2.89k stars 212 forks source link

Rollout#activate returns false #165

Open etherbob opened 2 years ago

etherbob commented 2 years ago

In the past when using $rollout.activate from the console there'd be a string response "OK"

After updating to rollout 2.5.0 my team-mates and I noticed that the activate method is returning false though it appears to be succeeding in activating the feature.

Wondering if this is intended behavior or some leakage from the save or notify_observers methods?

reneklacan commented 2 years ago

@etherbob Good catch. Yes, it's intended behaviour change.

etherbob commented 2 years ago

@etherbob Good catch. Yes, it's intended behaviour change.

@reneklacan would you say a little more about the reasoning behind the change? I was trying to find a ticket or changelog entry so I could understand it and share with some colleagues.

etherbob commented 1 year ago

@reneklacan specifically the confusion for us is that having #activate return false at the console level seems to indicate failure. If that's intentional it'd be great to have some docs that say what false is meant to imply.