search

fetrarij / ngx-daterangepicker-material

Pure Angular 2+ date range picker with material design theme, a demo here:
https://fetrarij.github.io/ngx-daterangepicker-material/
MIT License
249 stars 252 forks source link

ts changes #481

Closed chrisalexeev closed 1 year ago

chrisalexeev commented 1 year ago

fixes #471

Describe the bug Code is not compiling due to this error in daterangepicker.component.d.ts : The return type of a 'get' accessor must be assignable to its 'set' accessor type Type 'null' is not assignable to type 'string | Dayjs'.

The issue is valid for attributes maxDate and minDate

To Reproduce Steps to reproduce the behavior:

Compile Expected behavior maxDate and minDate should have the same type so it's follow the typescript rules

devnarayan commented 1 year ago

@fetrarij pls merge this pull request