Issue 99

[janbar]

Hi Christian,

It resolves issue #99. Also I reviewed log in OpenLiveStream to send "done" when done. This is important to know when "prologue" done because two threads share the recorder lock during setup (Open & Chain update). Br.

[janbar]

Issue is resolved.

[janbar]

But guys said there a read issue with analog channel. There is an interesting thing, the internal myth protocol can read analog channel without issue. I investigate about.

[janbar]

It is really weird because cmyth_file_seek() codes are almost identical between our cmyth and internal cmyth. The only change: the returned position is used to set file_pos. I checked returned values by the backend and they are good. So the problem is elsewhere. Does XBMC use the same player ? same rules ?

[janbar]

One thing: in internal cmyth the seek function for live stream is not provided. Seek return always -1. It can be use only for recordings. Have you any idea Christian ?

[janbar]

An other question: Currently i return error (-1) on bad seek. But in PVR interface i see:
/*!

• Seek in a live stream on a backend that supports timeshifting.
• @param iPosition The position to seek to.
• @param iWhence ?
• @return The new position.
• @remarks Optional, and only used if bHandlesInputStream is set to true. Return -1 if this add-on won't provide this function. */ long long SeekLiveStream(long long iPosition, int iWhence = SEEK_SET);

So in error we must returns (-1) or finally the unchanged current position ?

[fetzerch]

This is a bit difficult for me to understand. The first two patches fix the crash, so far so good. But how are the buffer changes related to this? Do you plan to remove the logic that adapts the read limit or is this for testing purposes only?

I've checked XBMC code, the return value of the SeekLiveStream function is handled in the player. The file based implementations (curl, smb, ...) return -1 on error or if you try to seek to an invalid position. So I guess we should do the same.

And yes, seeking for Live TV has been enabled for the timeshift feature in XBMC. It's not supported by the XBMC internal cmyth code.

[janbar]

Hi Christian, i removed commit about "remove buffer limit". The issue is resolved. It impacted also Mythtv 0.24 which does not generate the first dummy file and sometimes 0.25 and 0.26. It could be considered as critical. About "analog channel", i will try to find a solution with a chance and i will make a new PR.

[fetzerch]

thanks, merged