search

feulf / raintpl3

The easiest Template Engine for PHP
https://feulf.github.io/raintpl
258 stars 57 forks source link

update to MIT licence #187

Closed mirabilos closed 6 years ago

mirabilos commented 6 years ago

as requested in https://github.com/feulf/raintpl3/issues/186

Note to others: pending review by @feulf and merging into master to become binding

feulf commented 6 years ago

Looks good, aside the test failing in PHP 5.2. Again I stop supporting this project so, if someone wants to fix that test will be happy to merge it

mirabilos commented 6 years ago

Federico Ulfo dixit:

Looks good, aside the test failing in PHP 5.2.

That’s because the test runs in a *buntu trusty (14.04, waaaaay old) environment, but PHP 5.2 is only available in precise (12.04, even older and, by now, so long out of support it’s frozen and insecure).

(Yes, I actually looked.)

Thanks for acknowledging and merging! I’ll update the Debian package once you’ll publish the next release (at least tag it).

feulf commented 6 years ago

Good point. I’ll tag this release.

Sent from my iPhone

On Jun 8, 2018, at 5:59 PM, mirabilos notifications@github.com wrote:

Federico Ulfo dixit:

Looks good, aside the test failing in PHP 5.2.

That’s because the test runs in a *buntu trusty (14.04, waaaaay old) environment, but PHP 5.2 is only available in precise (12.04, even older and, by now, so long out of support it’s frozen and insecure).

(Yes, I actually looked.)

Thanks for acknowledging and merging! I’ll update the Debian package once you’ll publish the next release (at least tag it). — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.