feurix / hatop

Interactive ncurses client for the HAProxy TCP/HTTP load balancer
GNU General Public License v3.0
93 stars 19 forks source link

Suggestions to increase HAPROXY_STAT_MAX_SERVICES to >100 #2

Open joshuaboniface opened 7 years ago

joshuaboniface commented 7 years ago

Currently HAPROXY_STAT_MAX_SERVICES is hardcoded at 100. This is fine for most use cases but I've got a few HAProxy instances with >100 backend services, so with this setting as-is hatop is very limited. To work around this I've manually edited the binary to support 500 services, and in my experience the performance and functionality remains the same (or perhaps a little slower on the larger instances, but still usable).

I'd like to suggest either including this as an optional flag to the command-line, or perhaps just increasing it to a larger number like 500.

geor-g commented 7 years ago

+1

I'm interested in this as well.

bzed commented 6 years ago

+1 from me, too. I have my own patched hatop with HAPROXY_STAT_MAX_SERVICES=1000, works just fine.

jhunt commented 4 years ago

I bumped the HAPROXY_STAT_MAX_SERVICES constant in https://github.com/jhunt/hatop/commit/1e06e4ff6abdcc46501784f6ea4655c9550fe359.

Having heard nothing from @feurix for quite a while now, I've gone ahead and forked this over at https://github.com/jhunt/hatop, where I intend to continue maintenance for the foreseeable future.