search

feus4177 / socketIO-client-2

A socket.io client library for Python
http://pypi.python.org/pypi/socketIO-client-2
MIT License
16 stars 15 forks source link

Fix Invalid Namespace Hanging #4

Closed wilsonge closed 8 years ago

wilsonge commented 8 years ago

If you try and connect to an Invalid namespace you get an error back - but without any handler you end up just hanging (this issue was previously described in more detail here: invisibleroads#84)

I'm not sure whether this belongs in this SocketIO "namespace" or the parent EngineIO - welcome to adjust. Also welcome to adjust on the exception (whether Socket IO specific or another generic Python one)

wilsonge commented 8 years ago

@feus4177 any ideas on this - it's pretty annoying to have to have to extend the class every time just to add this in :(

feus4177 commented 8 years ago

Hey, sorry about the delay, I was on vacation. It looks like you've got the right idea but could you change it to just ConnectionError and add the import statement?

wilsonge commented 8 years ago

Apologies for the delay! Implemented the ConnectionError as you requested. Hope you had a nice holiday :)

feus4177 commented 8 years ago

Alright thanks.