search

fewieden / MMM-AlarmClock

Alarm Clock Module for MagicMirror²
MIT License
47 stars 18 forks source link

Suggestion #24

Closed cowboysdude closed 5 years ago

cowboysdude commented 5 years ago

Platform (Hardware/OS): Any Node version: Current MagicMirror version: ANY Module version: Dev Description of the issue: Not an issue a suggestion for enhancement. Why not just make this a clock with an alarm clock? Makes much more sense. You could show the time and if there's an alarm show that under the time... Just and idea.

fewieden commented 5 years ago

Not sure if it is easy to implement, because the clock is rerendering every second, but when an aalarm fires this would repeat just the first second of the sound for the specified timeframe.

cowboysdude commented 5 years ago

Couldn't that b implemented in a different js file and Caledonia by the clock ?

On Wed, Jan 9, 2019, 1:59 AM fewieden <notifications@github.com wrote:

Not sure if it is easy to implement, because the clock is rerendering every second, but when an aalarm fires this would repeat just the first second of the sound for the specified timeframe.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/fewieden/MMM-AlarmClock/issues/24#issuecomment-452592229, or mute the thread https://github.com/notifications/unsubscribe-auth/AKgOEGeOVLeudQEWkXKGGPcpIc9eb5yQks5vBZNDgaJpZM4Z2jf4 .

fewieden commented 5 years ago

I'm not sure if I understood your last message

cowboysdude commented 5 years ago

Yeah me either LOL Was on my phone and error correct is NOT your friend :) Let me see if I can figure out the code here :)

What I typed or thought I did was: Couldn't the alarm be implemented in a different file and called by the clock js? Basically merging two files into one......BUT I see that that is just not practical at all...... seems like too much work for a simple alarm clock! :) I'm going to close this as it's not even an issue more a question.