Configurable query - Githubissues

fewieden / MMM-MovieInfo

Upcoming Movie Info Module for MagicMirror²

MIT License

13 stars 6 forks source link

Closed dr4ke616 closed 7 years ago

dr4ke616 commented 7 years ago

Enhancement to allow configurable based queries.

Summary of changes:

datejs dependancy needed to be added to allow for human readable time based queries.
Code added to read and serialise query from config into url encoded parameters.
README updated with examples.

dr4ke616 commented 7 years ago

Hey, im not sure how to resolve the travis build issue. As for the security risk, is that a bad thing seen as its used only as a mirror module?

fewieden commented 7 years ago

i will take care about travis, as it is not set up correctly yet.

will look into this pr(vulnerability and functionality) tomorrow

fewieden commented 7 years ago

ok i have linted everything and removed datejs and used momentjs instead, what do you think about discover date part?

dr4ke616 commented 7 years ago

Looks nice, and removes the extra dependancy. 👍