search

fewieden / MMM-NHL

National Hockey League Module for MagicMirror²
MIT License
10 stars 11 forks source link

UI tweaks #11

Closed dannoh closed 3 years ago

dannoh commented 3 years ago

Fixed Vegas icon. Added PPD support. Added config for in game refresh… Added condensed text Added config for toggling names and logos (trying to shrink the size of the module a bit)

fewieden commented 3 years ago

@dannoh thank you for your contribution. I started recently a complete refactoring of this module for the new season. Yesterday I stayed up late to get the data from the API for some live games. I'm trying to go through your changes below:

  1. Fixed Vegas Icon
    • The new version of the module is no longer using local icons, instead, I retrieve them now from a remote location.
  2. Removed npm install from README (not needed and is huge)
    • npm install is required for the modules used in the node_helper. If some of your parent directories have those dependencies inside the node_modules directories already, then indeed you don't have to install it, as this is how npm behaves/loads the modules. But this can lead to unknown side effects. First, it is not guaranteed that every user has this installed from somewhere else already. And the versions could have a breaking change and therefore might break the module in the future. However, I made a mistake 4 years ago when I specified the flag --productive instead of --production, which is causing also the installation of all development dependencies that are obviously not required to run the module.
  3. Added options: gameTimeReloadInterval for quicker reloads during games showNames can toggle team names showLogos can toggle team logos condensed use shorter names (OT instead of Overtime)
    • I will try to implement those config options to the refactoring of the module
  4. Support PPD games (Postponed)
    • I'm using a new API and I'm not sure yet if this information is available there. Maybe you can help me out here, the timezone difference makes it hard to check what the API returns during or close before games and I have close to zero knowledge about ice hockey :smile:

I'm going to push the current status of the refactoring to the develop branch today. Feel free to help me out implementing your changes there.

dannoh commented 3 years ago
  1. Great, I looked at switching to the NHL svgs but they didn't look good
  2. Ah that makes sense, I'm new to MMM. I just noticed the huge amount of packages it installed and that I didn't 'need' any
  3. Some of these config options are important to me anyways. The scores are too wide, and they stretch out other controls on that side of my mirror. Hiding the names I like, the condensed we could probably get rid of, and just tweak some of the english translation text.
  4. PPD will likely come up again at some point this season, depending on the api you are using it will be easy to find some for testing.

New Api: Are you still using the nhl.com api's? The next thing I was planning on doing was switching to the Schedule API so I could control the game list a bit better. I'm not a huge fan of how the nhl decides which games to return in the scoreboard api.

I'll take a look at the develop branch later today.

fewieden commented 3 years ago

I pushed the newest version to the develop branch