search

fex-team / fis-parser-node-sass

Use node-sass to parser sass for fis/fis3.
MIT License
31 stars 23 forks source link

Fixbug: throw error #38

Closed maxming2333 closed 7 years ago

maxming2333 commented 7 years ago

fixbug to #37

node-sass 文档明确指出

如果 importer 报错，要使用

done(new Error('doesn\'t exist!'));
// or return synchornously
return new Error('nothing to do here');

但是我们这里使用了 throw，最终导致release卡死

maxming2333 commented 7 years ago

review 的时候，点击 Ignore Spaces 吧

maxming2333 commented 7 years ago

要装一个 chrome 插件 Octo Mate

2betop commented 7 years ago

感谢！请用新版本 fis-parser-node-sass@1.0.1

maxming2333 commented 7 years ago

✅