fezhub / DSP-Mods

Dyson Sphere Program Mods
GNU Lesser General Public License v2.1
42 stars 11 forks source link

Fixed #25, added a feature to copy building rotation #26

Closed TrAceX99 closed 3 years ago

TrAceX99 commented 3 years ago
brokenmass commented 3 years ago

the pr looks good and the rotation fix is a better (and more generic) solution than the limited one I proposed in #23 (that i'm now closing).

Is there a reason why you check for buildPreview.desc.multiLevel && buildPreview.inputToSlot == 14 instead of a possibly simpler __instance.multiLevelCovering (that would also make the condition easier to understand) ?

TrAceX99 commented 3 years ago

Thank you for the suggestion, I've replaced the condition now. There was no particular reason, I just overlooked the multiLevelCovering flag