Closed fezzopro closed 1 year ago
Hi @fezzopro @Paul-tes π,
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
You have submitted a project, that has a broken link, kindly provide a link that leads to the Kanban board
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready π
Cheers, and Happy coding!πππ
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
Invalid Code Review Request does not count into the code reviews limit.
Hi @fezzopro and @Paul-tes Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!
βοΈ Good setup
[x] Kindly delete the no status
column on your board, all cards in no status
column should should be moved to the todo
column you should have only four columns: Todo, In Progress, In Review, DoneππΏ
[x] Kindly add a card to make sure there are no N+1 queries happening
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
You can also consider:
Cheers and Happy coding!πππ
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification @prolajumokeoni.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Hi Student ,
Changes Implemented βοΈ
Good job implementing the requirements :+1: Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! π
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Cheers and Happy coding!πππ
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag ichala in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
ISSUE DESCRIPTION
The following project concerns a Recipe application that will be developed using the Ruby on Rails framework. The Recipe App Kanban Board Setup can be accessed via this link.
To refresh on the requirements visit Sneak peek: Recipe app
TEAM MEMBERS