search

ff-notes / ron

Haskell implementation of RON and RON-RDT
BSD 3-Clause "New" or "Revised" License
65 stars 9 forks source link

reduceWireFrame introduces new op ids #94

Closed dkellner closed 5 years ago

dkellner commented 5 years ago

The black box tests in gritzko~ron-test even were modified and now differ from the upstream ones at https://github.com/gritzko/ron-test/blob/master/05-rga.out.ron (see commit fdf62dab558fe00a5fed8dedf3d359f0d0b4f9c5).

Is this correct behaviour? Could this (theoretically) lead to a collision when one replica creates op ids for another one?

cblp commented 5 years ago

This is only in chunk version, and @gritzko removed this field in current RON. Haskell version is slightly outdated. Will it be ok after removing chunk version concept?

cblp commented 5 years ago

I want to keep this issue open until the question is fully resolved.

dkellner commented 5 years ago

Thanks for the update! I guess it will be fine when these versions are gone altogether. This will happen with RON 2.1 and therefore #41, right?

cblp commented 5 years ago

Yes

cblp commented 5 years ago

Please review https://reviewable.io/reviews/ff-notes/ron/97

cblp commented 5 years ago

fixed in #97 If you have any concern please reopen.