search

ff14-advanced-market-search / AzerothAuctionAssassin

Apache License 2.0
4 stars 6 forks source link

1.0.19.1 #100

Closed cohenaj194 closed 1 month ago

cohenaj194 commented 1 month ago

make version updates easy

Summary by CodeRabbit

coderabbitai[bot] commented 1 month ago

Walkthrough

This update introduces a consistent versioning approach across the project by defining a new AAA_VERSION environment variable. This variable is used in both the GitHub Actions workflow for building Windows executables and in the Python application itself, ensuring that the version number is centrally managed and easily updated.

Changes

File Change Summary
.github/workflows/windows-exe-build.yml Added env section defining AAA_VERSION and updated version settings to use this variable.
AzerothAuctionAssassin.py Introduced AAA_VERSION constant and updated self.title assignment to use this constant with f-strings.

Poem

In code's embrace, a version sings,
"One point zero, nineteen point one," it brings.
Across the scripts, it finds its place,
Unifying numbers, with elegant grace.
A rabbit's joy, in code so neat,
Hopping through lines, a rhythmic beat.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to full the review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
cohenaj194 commented 1 month ago

@coderabbitai review the logs from the failed workflow job related to this PR:

2024-05-27T22:57:44.4791700Z ##[group]Run pip install -r requirements.txt
2024-05-27T22:57:44.4792150Z pip install -r requirements.txt
2024-05-27T22:57:44.4849110Z shell: /bin/bash -e {0}
2024-05-27T22:57:44.4849350Z env:
2024-05-27T22:57:44.4849530Z   AAA_VERSION: 1.0.19.1
2024-05-27T22:57:44.4849870Z   pythonLocation: /Users/runner/hostedtoolcache/Python/3.11.9/arm64
2024-05-27T22:57:44.4850240Z ##[endgroup]
2024-05-27T22:57:45.5340440Z Collecting certifi==2023.11.17 (from -r requirements.txt (line 8))
2024-05-27T22:57:45.5966700Z   Downloading certifi-2023.11.17-py3-none-any.whl.metadata (2.2 kB)
2024-05-27T22:57:45.6657610Z Collecting charset-normalizer==3.3.2 (from -r requirements.txt (line 9))
2024-05-27T22:57:45.6779560Z   Downloading charset_normalizer-3.3.2-cp311-cp311-macosx_11_0_arm64.whl.metadata (33 kB)
2024-05-27T22:57:45.7066090Z Collecting idna==3.6 (from -r requirements.txt (line 10))
2024-05-27T22:57:45.7193260Z   Downloading idna-3.6-py3-none-any.whl.metadata (9.9 kB)
2024-05-27T22:57:45.7420300Z Collecting PyQt5==5.15.10 (from -r requirements.txt (line 11))
2024-05-27T22:57:45.7542760Z   Downloading PyQt5-5.15.10-cp37-abi3-macosx_11_0_arm64.whl.metadata (2.1 kB)
2024-05-27T22:57:45.7698500Z ERROR: Could not find a version that satisfies the requirement PyQt5-Qt5==5.15.2 (from versions: 5.15.11, 5.15.12, 5.15.13)
2024-05-27T22:57:45.7699290Z ERROR: No matching distribution found for PyQt5-Qt5==5.15.2
2024-05-27T22:57:45.9318870Z ##[error]Process completed with exit code 1.