Closed jxbt closed 8 months ago
The changes streamline the development process by disabling the signing of executables and enhancing the script execution in a Windows environment. Modifications include commenting out the executable signing step, adjusting the execution of Python scripts by adding a new parameter and setting the working directory, and dynamically updating the application's icon based on the execution context. These adjustments simplify development workflows and improve application flexibility.
File Path | Change Summary |
---|---|
.github/workflows/windows-exe-build.yml |
Disabled the "Sign Executable" step by commenting out the relevant code block. |
.../AzerothAuctionAssassin/Program.cs |
Added appPath parameter and set working directory in ExecuteShellCommand function. |
AzerothAuctionAssassin.py |
Dynamically set the icon file path based on the application's execution context (Windows binary). |
🐇✨
Changes here, changes there,
Code adapts with flair and care.
A rabbit hops, with joy it shares,
For better scripts, a fresh new air.
🚀🌟
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
this is a fix for the app icon issue in windows, the fix is implemented via checking if the
windowsApp_Path
global variable is set which will have a value when the python app is invoked from the windows binary.Summary by CodeRabbit
Chores
New Features
Style