ff14-advanced-market-search / AzerothAuctionAssassin

Apache License 2.0
9 stars 11 forks source link

Use marketshare to recommend snipe lists #43

Open cohenaj194 opened 9 months ago

cohenaj194 commented 9 months ago

This api basically tells people whats valuable and what they should snipe https://saddlebagexchange.com/wow/marketshare

People issue dont understand it enough to use it. Right now you can download the CSV, grab the item names, separate them by the ^ character and then import directly as a snipe list. Thats too many steps the app should just make a direct api request and get the data directly.

Just make this braindead and let people do a marketshare search in the app. This makes a list of valuable items by id with the average price included. We take this list and turn it into a snipe list like we do with general imports (nothing fancy like PBS).

cohenaj194 commented 9 months ago

have the basic idea up in this branch https://github.com/ff14-advanced-market-search/AzerothAuctionAssassin/tree/recommendations-page

fyi heres the api used too get these details https://app.swaggerhub.com/apis/SaddlebagExchange/wow/1.0.0#/default/post_api_wow_itemstats

heres the info on all the wow categories and subcategories https://github.com/ff14-advanced-market-search/saddlebag-with-pockets/wiki/WoW-item-classes-and-subclasses#subclasses

note that i commented out the categories that are commodity only and will not show up on the scan, i may add commodity sniping features in at some point in the future https://github.com/ff14-advanced-market-search/AzerothAuctionAssassin/blob/recommendations-page/AzerothAuctionAssassin.py#L703-L718

cohenaj194 commented 5 months ago

This broke alot so lets make it a separate app and not touch the main sniper

https://github.com/ff14-advanced-market-search/AzerothAuctionAssassin/blob/1.1.0/AzerothAuctionTarget.py

ref: https://github.com/ff14-advanced-market-search/AzerothAuctionAssassin/issues/73

cohenaj194 commented 5 months ago
$ pip install -U vulture
Collecting vulture
  Downloading vulture-2.11-py2.py3-none-any.whl.metadata (23 kB)
Downloading vulture-2.11-py2.py3-none-any.whl (27 kB)
Installing collected packages: vulture
Successfully installed vulture-2.11

$ vulture AzerothAuctionTarget.py 
AzerothAuctionTarget.py:22: unused import 'breeze_resources' (90% confidence)
AzerothAuctionTarget.py:31: unused import 'QObject' (90% confidence)
AzerothAuctionTarget.py:101: unused method 'run' (60% confidence)
AzerothAuctionTarget.py:131: unused method 'run' (60% confidence)
AzerothAuctionTarget.py:382: unused attribute 'pet_custom_categories' (60% confidence)
AzerothAuctionTarget.py:1376: unused attribute 'ilvl_items' (60% confidence)
AzerothAuctionTarget.py:1880: unused method 'validate_application_settings' (60% confidence)
AzerothAuctionTarget.py:2425: unused method 'validate_item_lists' (60% confidence)
AzerothAuctionTarget.py:2498: unused method 'start_alerts' (60% confidence)
AzerothAuctionTarget.py:2561: unused method 'stop_alerts' (60% confidence)