search

ff14-advanced-market-search / AzerothAuctionAssassin

Apache License 2.0
9 stars 11 forks source link

bump versions 1.0.19.2 #94

Closed cohenaj194 closed 6 months ago

cohenaj194 commented 6 months ago

Summary by CodeRabbit

coderabbitai[bot] commented 6 months ago

Walkthrough

The recent updates primarily focus on version increments across several files. The version number for the app has been updated from 1.0.19 to 1.0.19.2. This change is reflected in the build workflow, the app's title, and the release tags. Additionally, the requirements.txt file has been updated to include newer versions of PyQt5-Qt5 and requests.

Changes

Files / Paths Change Summary
.github/workflows/windows-exe-build.yml Updated the version number from 1.0.19 to 1.0.19.2 in the version file, release tag, and name.
AzerothAuctionAssassin.py Changed the title attribute in the App class to reflect the new version 1.0.19.2.
requirements.txt Updated PyQt5-Qt5 from 5.15.2 to 5.15.11 and requests from 2.31.0 to 2.32.0.

In the realm of code so bright,
Versions climb to a new height.
PyQt5 and requests, updated and new,
Azeroth Auction Assassin shines through.
With 1.0.19.2 in sight,
Our app takes flight!
🐇✨

[!TIP]

New Features and Improvements ## Review Settings Introduced new personality profiles for code reviews. Users can now select between "Chill" and "Assertive" review tones to tailor feedback styles according to their preferences. The "Assertive" profile posts more comments and nitpicks the code more aggressively, while the "Chill" profile is more relaxed and posts fewer comments. ## AST-based Instructions CodeRabbit offers customizing reviews based on the Abstract Syntax Tree (AST) pattern matching. Read more about AST-based instructions in the [documentation](https://docs.coderabbit.ai/guides/review-instructions#ast-based). ## Community-driven AST-based Rules We are kicking off a community-driven initiative to create and share AST-based rules. Users can now contribute their AST-based rules to detect security vulnerabilities, code smells, and anti-patterns. Please see the [ast-grep-essentials](https://github.com/coderabbitai/ast-grep-essentials) repository for more information. ## New Static Analysis Tools We are continually expanding our support for static analysis tools. We have added support for `biome`, `hadolint`, and `ast-grep`. Update the settings in your `.coderabbit.yaml` file or head over to the settings page to enable or disable the tools you want to use. ## Tone Settings Users can now customize CodeRabbit to review code in the style of their favorite characters or personalities. Here are some of our favorite examples: - Mr. T: "You must talk like Mr. T in all your code reviews. I pity the fool who doesn't!" - Pirate: "Arr, matey! Ye must talk like a pirate in all yer code reviews. Yarrr!" - Snarky: "You must be snarky in all your code reviews. Snark, snark, snark!" ## Revamped Settings Page We have redesigned the settings page for a more intuitive layout, enabling users to find and adjust settings quickly. This change was long overdue; it not only improves the user experience but also allows our development team to add more settings in the future with ease. Going forward, the changes to `.coderabbit.yaml` will be reflected in the settings page, and vice versa. ## Miscellaneous - Turn off free summarization: You can switch off free summarization of PRs opened by users not on a paid plan using the `enable_free_tier` setting. - Knowledge-base scope: You can now set the scope of the knowledge base to either the repository (`local`) or the organization (`global`) level using the `knowledge_base` setting. In addition, you can specify Jira project keys and Linear team keys to limit the knowledge base scope for those integrations. - High-level summary placement: You can now customize the location of the high-level summary in the PR description using the `high_level_summary_placeholder` setting (default `@coderabbitai summary`). - Revamped request changes workflow: You can now configure CodeRabbit to auto-approve or request changes on PRs based on the review feedback using the `request_changes_workflow` setting.

[!WARNING]

Review ran into problems

Problems (1) * Git: Failed to clone repository. Please contact CodeRabbit support.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
cohenaj194 commented 6 months ago

@coderabbitai this update to the requirements isnt working heres the error 


Run # Create the python-embedded directory if it doesn't exist
  # Create the python-embedded directory if it doesn't exist
  $pythonEmbeddedDir = ".\python-embedded"
  If (-Not (Test-Path $pythonEmbeddedDir)) {
      New-Item -ItemType Directory -Force -Path $pythonEmbeddedDir
  }
  # Download the embedded Python zip
  curl https://www.python.org/ftp/python/3.11.4/python-3.11.4-embed-win3[2](https://github.com/ff14-advanced-market-search/AzerothAuctionAssassin/actions/runs/9236663959/job/25412759763#step:4:2).zip -o "python.zip"
  # Extract the Python zip
  Expand-Archive -Path "python.zip" -DestinationPath $pythonEmbeddedDir -Force
  # Download pip.pyz
  curl https://bootstrap.pypa.io/pip/pip.pyz -o "$pythonEmbeddedDir\pip.pyz"
  # Install packages from requirements.txt using the embedded Python and pip.pyz
  & "$pythonEmbeddedDir\python.exe" "$pythonEmbeddedDir\pip.pyz" install -r .\requirements.txt --target=".\Lib\site-packages\"
  Remove-Item -Recurse -Force .\python-embedded
  Remove-Item -Force python.zip
  shell: C:\Program Files\PowerShell\7\pwsh.EXE -command ". '{0}'"

    Directory: D:\a\***\***

Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
d----           5/25/2024  4:06 PM                python-embedded
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 9[3](https://github.com/ff14-advanced-market-search/AzerothAuctionAssassin/actions/runs/9236663959/job/25412759763#step:4:3)71k  100 9371k    0     0  49.6M      0 --:--:-- --:--:-- --:--:-- 57.9M
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 2030k  100 2030k    0     0  8068k      0 --:--:-- --:--:-- --:--:-- 8122k
Collecting certifi==2023.11.17 (from -r .\requirements.txt (line 8))
  Downloading certifi-2023.11.17-py3-none-any.whl.metadata (2.2 kB)
Collecting charset-normalizer==3.3.2 (from -r .\requirements.txt (line 9))
  Downloading charset_normalizer-3.3.2-cp311-cp311-win32.whl.metadata (3[4](https://github.com/ff14-advanced-market-search/AzerothAuctionAssassin/actions/runs/9236663959/job/25412759763#step:4:4) kB)
Collecting idna==3.6 (from -r .\requirements.txt (line 10))
  Downloading idna-3.6-py3-none-any.whl.metadata (9.9 kB)
Collecting PyQt[5](https://github.com/ff14-advanced-market-search/AzerothAuctionAssassin/actions/runs/9236663959/job/25412759763#step:4:5)==5.15.10 (from -r .\requirements.txt (line 11))
  Downloading PyQt5-5.15.10-cp3[7](https://github.com/ff14-advanced-market-search/AzerothAuctionAssassin/actions/runs/9236663959/job/25412759763#step:4:7)-abi3-win32.whl.metadata (2.2 kB)
ERROR: Could not find a version that satisfies the requirement PyQt5-Qt5==5.15.11 (from versions: 5.15.2)
ERROR: No matching distribution found for PyQt5-Qt5==5.15.[11](https://github.com/ff14-advanced-market-search/AzerothAuctionAssassin/actions/runs/9236663959/job/25412759763#step:4:11)```
coderabbitai[bot] commented 6 months ago

[!TIP] For best results, initiate chat on the files or code changes.

@cohenaj194, it seems like the issue is due to the specified version of PyQt5-Qt5==5.15.11 in your requirements.txt file, which isn't available in the Python package index. The error message indicates that the closest available version is 5.15.2.

Here's what you can do:

  1. Verify the Version: Double-check the version number. If 5.15.11 was a typo, correct it to 5.15.2 or another version that is available.
  2. Check Available Versions: You can check the available versions of PyQt5-Qt5 on PyPI or by using pip: 
    pip install PyQt5-Qt5==

    This command will list available versions for PyQt5-Qt5.

Please update the version in your requirements.txt accordingly and try running the installation process again. If you need further assistance, feel free to ask!

coderabbitai[bot] commented 6 months ago

[!TIP] For best results, initiate chat on the files or code changes.

@cohenaj194, it seems there was an issue with verifying the availability of PyQt5-Qt5 version 5.15.11 directly through a script due to environment limitations. However, based on the error message you encountered, it appears that version 5.15.11 of PyQt5-Qt5 might not be available.

I recommend checking the PyPI PyQt5-Qt5 page or the official PyQt documentation to confirm the available versions. If version 5.15.11 is indeed not available, you should update your requirements.txt to use a version that is available, such as 5.15.2, which was mentioned in the error message.

If you need further assistance with this or any other issues, feel free to ask!

Analysis chain
Scripts executed The following scripts were executed for the analysis: --- Script: ```shell #!/bin/bash # Check for available versions of PyQt5-Qt5 on PyPI pip search PyQt5-Qt5 ``` Length of output: 93
cohenaj194 commented 6 months ago

@coderabbitai review the logs from the failed workflow related to this PR:

https://github.com/ff14-advanced-market-search/AzerothAuctionAssassin/actions/runs/9033222041/job/24823270540

coderabbitai[bot] commented 6 months ago

[!TIP] For best results, initiate chat on the files or code changes.

@cohenaj194, to review the logs from the failed workflow related to this PR, you can follow these steps:

  1. Access the Workflow Run: Navigate to the provided URL GitHub Actions Run. This link should take you directly to the specific job that failed.

  2. Review the Logs: On the job page, you will find detailed logs for each step executed in the workflow. Look for steps that have failed (usually indicated in red) to understand what went wrong. Expand these sections to see detailed error messages and outputs.

  3. Identify the Issue: Based on the error messages and the context of the failure, identify what might be causing the issue. Common problems could be related to configuration errors, missing dependencies, or incorrect paths.

  4. Resolve the Issue: Once you identify the problem, you can make the necessary changes in your repository to resolve the issue. This might involve updating workflow files, fixing scripts, or adjusting configurations.

If you encounter specific errors or issues that you need help with, feel free to share them here, and I can provide more targeted assistance!

If you need further guidance on navigating or interpreting the logs, let me know!

cohenaj194 commented 6 months ago

@coderabbitai review the logs from the failed workflow related to this PR:


2024-05-10T13:54:26.1300310Z Collecting certifi==2023.11.17 (from -r requirements.txt (line 8))
2024-05-10T13:54:26.1880050Z   Downloading certifi-2023.11.17-py3-none-any.whl.metadata (2.2 kB)
2024-05-10T13:54:26.2627050Z Collecting charset-normalizer==3.3.2 (from -r requirements.txt (line 9))
2024-05-10T13:54:26.2759520Z   Downloading charset_normalizer-3.3.2-cp311-cp311-macosx_11_0_arm64.whl.metadata (33 kB)
2024-05-10T13:54:26.3224440Z Collecting idna==3.6 (from -r requirements.txt (line 10))
2024-05-10T13:54:26.3339030Z   Downloading idna-3.6-py3-none-any.whl.metadata (9.9 kB)
2024-05-10T13:54:26.3572810Z Collecting PyQt5==5.15.10 (from -r requirements.txt (line 11))
2024-05-10T13:54:26.3689420Z   Downloading PyQt5-5.15.10-cp37-abi3-macosx_11_0_arm64.whl.metadata (2.1 kB)
2024-05-10T13:54:26.3853460Z ERROR: Could not find a version that satisfies the requirement PyQt5-Qt5==5.15.2 (from versions: 5.15.11, 5.15.12, 5.15.13)
2024-05-10T13:54:26.3854160Z ERROR: No matching distribution found for PyQt5-Qt5==5.15.2
2024-05-10T13:54:26.5713840Z ##[error]Process completed with exit code 1.```
coderabbitai[bot] commented 6 months ago

[!TIP] For best results, initiate chat on the files or code changes.

@cohenaj194, the logs you provided indicate an issue with the specified version of PyQt5-Qt5 in your requirements.txt file. The error message clearly states that version 5.15.2 is not available, and the available versions are 5.15.11, 5.15.12, and 5.15.13.

Here's how you can resolve this issue:

  1. Update the requirements.txt File: Change the version of PyQt5-Qt5 in your requirements.txt file to one of the available versions (5.15.11, 5.15.12, or 5.15.13). For example: 
    PyQt5-Qt5==5.15.11
  2. Re-run the Workflow: After updating the requirements.txt file, commit the changes and re-run the workflow to see if the issue is resolved.

This should fix the error you're encountering with the package installation. If you encounter any more issues or need further assistance, feel free to ask!

cohenaj194 commented 6 months ago

@coderabbitai review the logs from the failed workflow job related to this PR:

2024-05-10T13:54:25.0936470Z ##[endgroup]
2024-05-10T13:54:26.1300310Z Collecting certifi==2023.11.17 (from -r requirements.txt (line 8))
2024-05-10T13:54:26.1880050Z   Downloading certifi-2023.11.17-py3-none-any.whl.metadata (2.2 kB)
2024-05-10T13:54:26.2627050Z Collecting charset-normalizer==3.3.2 (from -r requirements.txt (line 9))
2024-05-10T13:54:26.2759520Z   Downloading charset_normalizer-3.3.2-cp311-cp311-macosx_11_0_arm64.whl.metadata (33 kB)
2024-05-10T13:54:26.3224440Z Collecting idna==3.6 (from -r requirements.txt (line 10))
2024-05-10T13:54:26.3339030Z   Downloading idna-3.6-py3-none-any.whl.metadata (9.9 kB)
2024-05-10T13:54:26.3572810Z Collecting PyQt5==5.15.10 (from -r requirements.txt (line 11))
2024-05-10T13:54:26.3689420Z   Downloading PyQt5-5.15.10-cp37-abi3-macosx_11_0_arm64.whl.metadata (2.1 kB)
2024-05-10T13:54:26.3853460Z ERROR: Could not find a version that satisfies the requirement PyQt5-Qt5==5.15.2 (from versions: 5.15.11, 5.15.12, 5.15.13)
2024-05-10T13:54:26.3854160Z ERROR: No matching distribution found for PyQt5-Qt5==5.15.2
2024-05-10T13:54:26.5713840Z ##[error]Process completed with exit code 1.
coderabbitai[bot] commented 6 months ago

[!TIP] For best results, initiate chat on the files or code changes.

@cohenaj194, the logs you've provided indicate an issue with the specified version of PyQt5-Qt5 in your requirements.txt file. The error message clearly states that version 5.15.2 is not available, and the available versions are 5.15.11, 5.15.12, and 5.15.13.

Here's how you can resolve this issue:

  1. Update the requirements.txt File: Change the version of PyQt5-Qt5 in your requirements.txt file to one of the available versions (5.15.11, 5.15.12, or 5.15.13). For example: 
    PyQt5-Qt5==5.15.11
  2. Re-run the Workflow: After updating the requirements.txt file, commit the changes and re-run the workflow to see if the issue is resolved.

This should fix the error you're encountering with the package installation. If you encounter any more issues or need further assistance, feel free to ask!

cohenaj194 commented 6 months ago

@coderabbitai review the logs from the failed workflow job related to this PR:

2024-05-10T13:54:25.0936470Z ##[endgroup]
2024-05-10T13:54:26.1300310Z Collecting certifi==2023.11.17 (from -r requirements.txt (line 8))
2024-05-10T13:54:26.1880050Z   Downloading certifi-2023.11.17-py3-none-any.whl.metadata (2.2 kB)
2024-05-10T13:54:26.2627050Z Collecting charset-normalizer==3.3.2 (from -r requirements.txt (line 9))
2024-05-10T13:54:26.2759520Z   Downloading charset_normalizer-3.3.2-cp311-cp311-macosx_11_0_arm64.whl.metadata (33 kB)
2024-05-10T13:54:26.3224440Z Collecting idna==3.6 (from -r requirements.txt (line 10))
2024-05-10T13:54:26.3339030Z   Downloading idna-3.6-py3-none-any.whl.metadata (9.9 kB)
2024-05-10T13:54:26.3572810Z Collecting PyQt5==5.15.10 (from -r requirements.txt (line 11))
2024-05-10T13:54:26.3689420Z   Downloading PyQt5-5.15.10-cp37-abi3-macosx_11_0_arm64.whl.metadata (2.1 kB)
2024-05-10T13:54:26.3853460Z ERROR: Could not find a version that satisfies the requirement PyQt5-Qt5==5.15.2 (from versions: 5.15.11, 5.15.12, 5.15.13)
2024-05-10T13:54:26.3854160Z ERROR: No matching distribution found for PyQt5-Qt5==5.15.2
2024-05-10T13:54:26.5713840Z ##[error]Process completed with exit code 1.
coderabbitai[bot] commented 6 months ago

[!TIP] For best results, initiate chat on the files or code changes.

@cohenaj194, the logs you've provided indicate an issue with the specified version of PyQt5-Qt5 in your requirements.txt file. The error message clearly states that version 5.15.2 is not available, and the available versions are 5.15.11, 5.15.12, and 5.15.13.

Here's how you can resolve this issue:

  1. Update the requirements.txt File: Change the version of PyQt5-Qt5 in your requirements.txt file to one of the available versions (5.15.11, 5.15.12, or 5.15.13). For example: 
    PyQt5-Qt5==5.15.11
  2. Re-run the Workflow: After updating the requirements.txt file, commit the changes and re-run the workflow to see if the issue is resolved.

This should fix the error you're encountering with the package installation. If you encounter any more issues or need further assistance, feel free to ask!