ff14-advanced-market-search / saddlebag-with-pockets

This is the Frontend for the FF14 Marketplace
https://saddlebagexchange.com/
Apache License 2.0
31 stars 14 forks source link

weird forigen charactes in realm names #363

Open cohenaj194 opened 10 months ago

cohenaj194 commented 10 months ago

we have problems when it comes to wow eu names like

Pozzo dell'Eternita which becomes "Pozzo dell’Eternità" from the FE

short term fix is to have the links match the api https://github.com/ff14-advanced-market-search/saddlebag-with-pockets/pull/365

cohenaj194 commented 10 months ago

So there is a bigger problem with all the wow searches that allow you to send a realm name / server name instead of a realm id.

We should make things consistent by only using the realm / sever ids. Here are the following apis i neeed to update to make them accept a realm id.

Once I migrate them to just be able to use the realm id we can disable sending the realm name intead.

cohenaj194 commented 10 months ago

It looks like undermine has other issues with this too. I reached out to tell them.

I think this may be a bug but im noticing that the pages dont show content if i go directly to a url that has special characters in it ex: undermine.exchange/#eu-pozzo-delleternità/search/rousing , could you patch this and maybe have it work in a way that it could understand it without the special characters i.e. undermine.exchange/#eu-pozzo-delleternita/search/rousing fyi it works fine for anything without special foreign characters undermine.exchange/#eu-thrall/search/rousing