ff4j / ff4j-spring-boot-starter-parent

A spring boot starter for FF4J (Feature Flipping For Java)
Apache License 2.0
32 stars 26 forks source link

feat(service): add non-blocking response from service #350

Closed anupbaranwal closed 1 year ago

anupbaranwal commented 1 year ago

Description

Closes :

Checklist for self review:

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 97.77% and project coverage change: +0.05 :tada:

Comparison is base (ac8b234) 86.23% compared to head (aa2db8f) 86.29%.

:exclamation: Current head aa2db8f differs from pull request most recent head ed9028d. Consider uploading reports for the commit ed9028d to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #350 +/- ## ============================================ + Coverage 86.23% 86.29% +0.05% Complexity 206 206 ============================================ Files 51 51 Lines 465 467 +2 Branches 21 21 ============================================ + Hits 401 403 +2 Misses 51 51 Partials 13 13 ``` | [Impacted Files](https://app.codecov.io/gh/ff4j/ff4j-spring-boot-starter-parent/pull/350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ff4j) | Coverage Δ | | |---|---|---| | [...ain/kotlin/org/ff4j/services/MonitoringServices.kt](https://app.codecov.io/gh/ff4j/ff4j-spring-boot-starter-parent/pull/350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ff4j#diff-ZmY0ai1zcHJpbmctc2VydmljZXMvc3JjL21haW4va290bGluL29yZy9mZjRqL3NlcnZpY2VzL01vbml0b3JpbmdTZXJ2aWNlcy5rdA==) | `75.00% <50.00%> (ø)` | | | [...org/ff4j/spring/rest/api/resources/FF4jResource.kt](https://app.codecov.io/gh/ff4j/ff4j-spring-boot-starter-parent/pull/350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ff4j#diff-ZmY0ai1zcHJpbmctcmVzdC1hcGkvc3JjL21haW4va290bGluL29yZy9mZjRqL3NwcmluZy9yZXN0L2FwaS9yZXNvdXJjZXMvRkY0alJlc291cmNlLmt0) | `100.00% <100.00%> (ø)` | | | [.../ff4j/spring/rest/api/resources/FeatureResource.kt](https://app.codecov.io/gh/ff4j/ff4j-spring-boot-starter-parent/pull/350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ff4j#diff-ZmY0ai1zcHJpbmctcmVzdC1hcGkvc3JjL21haW4va290bGluL29yZy9mZjRqL3NwcmluZy9yZXN0L2FwaS9yZXNvdXJjZXMvRmVhdHVyZVJlc291cmNlLmt0) | `100.00% <100.00%> (ø)` | | | [.../spring/rest/api/resources/FeatureStoreResource.kt](https://app.codecov.io/gh/ff4j/ff4j-spring-boot-starter-parent/pull/350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ff4j#diff-ZmY0ai1zcHJpbmctcmVzdC1hcGkvc3JjL21haW4va290bGluL29yZy9mZjRqL3NwcmluZy9yZXN0L2FwaS9yZXNvdXJjZXMvRmVhdHVyZVN0b3JlUmVzb3VyY2Uua3Q=) | `100.00% <100.00%> (ø)` | | | [...rg/ff4j/spring/rest/api/resources/GroupResource.kt](https://app.codecov.io/gh/ff4j/ff4j-spring-boot-starter-parent/pull/350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ff4j#diff-ZmY0ai1zcHJpbmctcmVzdC1hcGkvc3JjL21haW4va290bGluL29yZy9mZjRqL3NwcmluZy9yZXN0L2FwaS9yZXNvdXJjZXMvR3JvdXBSZXNvdXJjZS5rdA==) | `100.00% <100.00%> (ø)` | | | [...4j/spring/rest/api/resources/MonitoringResource.kt](https://app.codecov.io/gh/ff4j/ff4j-spring-boot-starter-parent/pull/350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ff4j#diff-ZmY0ai1zcHJpbmctcmVzdC1hcGkvc3JjL21haW4va290bGluL29yZy9mZjRqL3NwcmluZy9yZXN0L2FwaS9yZXNvdXJjZXMvTW9uaXRvcmluZ1Jlc291cmNlLmt0) | `100.00% <100.00%> (ø)` | | | [...ff4j/spring/rest/api/resources/PropertyResource.kt](https://app.codecov.io/gh/ff4j/ff4j-spring-boot-starter-parent/pull/350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ff4j#diff-ZmY0ai1zcHJpbmctcmVzdC1hcGkvc3JjL21haW4va290bGluL29yZy9mZjRqL3NwcmluZy9yZXN0L2FwaS9yZXNvdXJjZXMvUHJvcGVydHlSZXNvdXJjZS5rdA==) | `100.00% <100.00%> (ø)` | | | [...spring/rest/api/resources/PropertyStoreResource.kt](https://app.codecov.io/gh/ff4j/ff4j-spring-boot-starter-parent/pull/350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ff4j#diff-ZmY0ai1zcHJpbmctcmVzdC1hcGkvc3JjL21haW4va290bGluL29yZy9mZjRqL3NwcmluZy9yZXN0L2FwaS9yZXNvdXJjZXMvUHJvcGVydHlTdG9yZVJlc291cmNlLmt0) | `100.00% <100.00%> (ø)` | | | [.../src/main/kotlin/org/ff4j/services/FF4jServices.kt](https://app.codecov.io/gh/ff4j/ff4j-spring-boot-starter-parent/pull/350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ff4j#diff-ZmY0ai1zcHJpbmctc2VydmljZXMvc3JjL21haW4va290bGluL29yZy9mZjRqL3NlcnZpY2VzL0ZGNGpTZXJ2aWNlcy5rdA==) | `100.00% <100.00%> (ø)` | | | [...c/main/kotlin/org/ff4j/services/FeatureServices.kt](https://app.codecov.io/gh/ff4j/ff4j-spring-boot-starter-parent/pull/350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ff4j#diff-ZmY0ai1zcHJpbmctc2VydmljZXMvc3JjL21haW4va290bGluL29yZy9mZjRqL3NlcnZpY2VzL0ZlYXR1cmVTZXJ2aWNlcy5rdA==) | `100.00% <100.00%> (ø)` | | | ... and [4 more](https://app.codecov.io/gh/ff4j/ff4j-spring-boot-starter-parent/pull/350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ff4j) | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

anupbaranwal commented 1 year ago

The changes of this PR has been added in another PR https://github.com/ff4j/ff4j-spring-boot-starter-parent/pull/366