ffalcinelli / pydivert

A Python binding for WinDivert driver
GNU Lesser General Public License v3.0
200 stars 36 forks source link

Missing files in sdist #52

Open thatch opened 4 years ago

thatch commented 4 years ago

It appears that the manifest is missing at least one file necessary to build from the sdist for version 2.1.0. You're in good company, about 5% of other projects updated in the last year are also missing files.

(ignore that I'm building this in Linux; the same sdist is used on Windows)

+ /tmp/venv/bin/pip3 wheel --no-binary pydivert -w /tmp/ext pydivert==2.1.0
Looking in indexes: http://10.10.0.139:9191/root/pypi/+simple/
Collecting pydivert==2.1.0
  Downloading http://10.10.0.139:9191/root/pypi/%2Bf/f0e/150f4ff591b78/pydivert-2.1.0.tar.gz (91 kB)
Building wheels for collected packages: pydivert
  Building wheel for pydivert (setup.py): started
  Building wheel for pydivert (setup.py): finished with status 'error'
  ERROR: Command errored out with exit status 1:
   command: /tmp/venv/bin/python3 -u -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-wheel-fwu3zb3s/pydivert/setup.py'"'"'; __file__='"'"'/tmp/pip-wheel-fwu3zb3s/pydivert/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' bdist_wheel -d /tmp/pip-wheel-55m1mduk
       cwd: /tmp/pip-wheel-fwu3zb3s/pydivert/
  Complete output (71 lines):
  running bdist_wheel
  running build
  running build_py
  creating build
  creating build/lib
  creating build/lib/pydivert
  copying pydivert/__init__.py -> build/lib/pydivert
  copying pydivert/windivert.py -> build/lib/pydivert
  copying pydivert/util.py -> build/lib/pydivert
  copying pydivert/consts.py -> build/lib/pydivert
  creating build/lib/pydivert/windivert_dll
  copying pydivert/windivert_dll/__init__.py -> build/lib/pydivert/windivert_dll
  copying pydivert/windivert_dll/structs.py -> build/lib/pydivert/windivert_dll
  creating build/lib/pydivert/tests
  copying pydivert/tests/__init__.py -> build/lib/pydivert/tests
  copying pydivert/tests/test_windivert.py -> build/lib/pydivert/tests
  copying pydivert/tests/test_packet.py -> build/lib/pydivert/tests
  copying pydivert/tests/fixtures.py -> build/lib/pydivert/tests
  creating build/lib/pydivert/packet
  copying pydivert/packet/__init__.py -> build/lib/pydivert/packet
  copying pydivert/packet/udp.py -> build/lib/pydivert/packet
  copying pydivert/packet/tcp.py -> build/lib/pydivert/packet
  copying pydivert/packet/ip.py -> build/lib/pydivert/packet
  copying pydivert/packet/icmp.py -> build/lib/pydivert/packet
  copying pydivert/packet/header.py -> build/lib/pydivert/packet
  running egg_info
  writing pydivert.egg-info/PKG-INFO
  writing dependency_links to pydivert.egg-info/dependency_links.txt
  writing requirements to pydivert.egg-info/requires.txt
  writing top-level names to pydivert.egg-info/top_level.txt
  warning: Failed to find the configured license file 'LICENSE'
  reading manifest file 'pydivert.egg-info/SOURCES.txt'
  reading manifest template 'MANIFEST.in'
  writing manifest file 'pydivert.egg-info/SOURCES.txt'
  copying pydivert/windivert_dll/WinDivert32.dll -> build/lib/pydivert/windivert_dll
  copying pydivert/windivert_dll/WinDivert32.sys -> build/lib/pydivert/windivert_dll
  copying pydivert/windivert_dll/WinDivert64.dll -> build/lib/pydivert/windivert_dll
  copying pydivert/windivert_dll/WinDivert64.sys -> build/lib/pydivert/windivert_dll
  installing to build/bdist.linux-x86_64/wheel
  running install
  running install_lib
  creating build/bdist.linux-x86_64
  creating build/bdist.linux-x86_64/wheel
  creating build/bdist.linux-x86_64/wheel/pydivert
  creating build/bdist.linux-x86_64/wheel/pydivert/packet
  copying build/lib/pydivert/packet/header.py -> build/bdist.linux-x86_64/wheel/pydivert/packet
  copying build/lib/pydivert/packet/icmp.py -> build/bdist.linux-x86_64/wheel/pydivert/packet
  copying build/lib/pydivert/packet/ip.py -> build/bdist.linux-x86_64/wheel/pydivert/packet
  copying build/lib/pydivert/packet/tcp.py -> build/bdist.linux-x86_64/wheel/pydivert/packet
  copying build/lib/pydivert/packet/udp.py -> build/bdist.linux-x86_64/wheel/pydivert/packet
  copying build/lib/pydivert/packet/__init__.py -> build/bdist.linux-x86_64/wheel/pydivert/packet
  creating build/bdist.linux-x86_64/wheel/pydivert/tests
  copying build/lib/pydivert/tests/fixtures.py -> build/bdist.linux-x86_64/wheel/pydivert/tests
  copying build/lib/pydivert/tests/test_packet.py -> build/bdist.linux-x86_64/wheel/pydivert/tests
  copying build/lib/pydivert/tests/test_windivert.py -> build/bdist.linux-x86_64/wheel/pydivert/tests
  copying build/lib/pydivert/tests/__init__.py -> build/bdist.linux-x86_64/wheel/pydivert/tests
  creating build/bdist.linux-x86_64/wheel/pydivert/windivert_dll
  copying build/lib/pydivert/windivert_dll/WinDivert64.sys -> build/bdist.linux-x86_64/wheel/pydivert/windivert_dll
  copying build/lib/pydivert/windivert_dll/WinDivert64.dll -> build/bdist.linux-x86_64/wheel/pydivert/windivert_dll
  copying build/lib/pydivert/windivert_dll/WinDivert32.sys -> build/bdist.linux-x86_64/wheel/pydivert/windivert_dll
  copying build/lib/pydivert/windivert_dll/WinDivert32.dll -> build/bdist.linux-x86_64/wheel/pydivert/windivert_dll
  copying build/lib/pydivert/windivert_dll/structs.py -> build/bdist.linux-x86_64/wheel/pydivert/windivert_dll
  copying build/lib/pydivert/windivert_dll/__init__.py -> build/bdist.linux-x86_64/wheel/pydivert/windivert_dll
  copying build/lib/pydivert/consts.py -> build/bdist.linux-x86_64/wheel/pydivert
  copying build/lib/pydivert/util.py -> build/bdist.linux-x86_64/wheel/pydivert
  copying build/lib/pydivert/windivert.py -> build/bdist.linux-x86_64/wheel/pydivert
  copying build/lib/pydivert/__init__.py -> build/bdist.linux-x86_64/wheel/pydivert
  running install_egg_info
  Copying pydivert.egg-info to build/bdist.linux-x86_64/wheel/pydivert-2.1.0.egg-info
  running install_scripts
  error: [Errno 2] No such file or directory: 'LICENSE'
  ----------------------------------------
  ERROR: Failed building wheel for pydivert
  Running setup.py clean for pydivert
Failed to build pydivert
ERROR: Failed to build one or more wheels
thatch commented 4 years ago

This doesn't appear to happen when built from the repo.