ffd8 / P5LIVE

p5.js collaborative live-coding vj environment!
https://p5live.org
GNU General Public License v3.0
226 stars 35 forks source link

Remove executable flag on non-executable files #13

Closed osresearch closed 4 years ago

osresearch commented 5 years ago

Removed all of the execute bits from the non-executable files with:

find . -type f -print0 | xargs -0 chmod -x
ffd8 commented 5 years ago

This is interesting.. could you offer a quick reference to why this is necessary?

osresearch commented 5 years ago

It makes the directory listings inconsistent since ls and other commands flag and color executables. In this screenshot the Sortable.js and rga.js files have the +x bit set, so they show up differently:

Screenshot from 2019-05-30 09-40-19

However, they are not executable and don't have #! interpreter lines, so trying to run them produces an error:

unicycle:~/art/P5LIVE/includes/js: ./rga.js 
./rga.js: line 1: //: Is a directory
./rga.js: line 1: js-indent-level:: command not found
./rga.js: line 2: //: Is a directory
./rga.js: line 3: syntax error near unexpected token `('
./rga.js: line 3: `// rga.js - An implementation of the Replicated Growable Array (RGA) given in'
ffd8 commented 4 years ago

Thanks for the tip on this.. I ran it just to see what was happening and have already merged into the develop branch. Interesting to learn of this issue, as I don't browse files enough via CLI.