search

ffdev-info / wikidp-issues

An issues repository for resolving issues in Wikidata around the records relating to Digital Preservation
GNU General Public License v3.0
1 stars 0 forks source link

What happens if we change the SPARQL used to generate a signature file? #5

Closed ross-spencer closed 3 years ago

ross-spencer commented 3 years ago

Description of problem

Related to https://github.com/ross-spencer/WikiDP-Issues/issues/2 if we temporarily remove provenance from the SPARQL query used by Siegfried to generate a signature file, do we increase the chances of a Siegfried panic or other failure?

Ultimately, the mechanism should be robust, and shouldn't fall over.

I feel this is worth reflecting on, so perhaps as we work through some of the encoding/provenance issues still, let's see what the effect of changing up the SPARQL is and make sure that Siegfried can still worth with smaller graphs etc.

ross-spencer commented 3 years ago

Having done some work with #2 I can confirm that the functions handling the reading of the Wikidata SPARQL responses are pretty robust to the point where I think we can put in any SPARQL query and Roy won't panic. With provenance, because not all statements have this information anyway, Roy is already able to respond to this information being missing.